Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: Print the reason why the route-map and/or the index parsing is done #17556

Merged

Conversation

ton31337
Copy link
Member

@ton31337 ton31337 commented Dec 3, 2024

This would give maybe more information on what's going (Route-map: (null) ...) on with #17552.

@frrbot frrbot bot added the libfrr label Dec 3, 2024
@ton31337 ton31337 force-pushed the fix/add_route_map_action_reason branch from 704826a to 05f1111 Compare December 3, 2024 14:37
Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

lib/routemap.c Outdated Show resolved Hide resolved
This would give more details why at some point we return deny, no match, etc.

Before this we have sometimes (I don't know why), e.g.:

```
Route-map: null, prefix: 192.168.2.0/24, result: deny
```

Signed-off-by: Donatas Abraitis <[email protected]>
@ton31337 ton31337 force-pushed the fix/add_route_map_action_reason branch from 05f1111 to 5b976f0 Compare December 4, 2024 06:27
@riw777 riw777 merged commit f1ab0a0 into FRRouting:master Dec 4, 2024
11 checks passed
@ton31337 ton31337 deleted the fix/add_route_map_action_reason branch December 4, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants